Fix NPM-installed files with large UID/GID. #1157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some unknown reasons (*cough* Javascript *cough*), when NPM's `underscore` module is installed (as a dependency to Obographviz), its files are given some impossibly large UID and GID. This may prevent the final image from being used on systems where Docker runs in rootless mode. So after Obographviz is installed, we ensure that all files and directories under /usr/local/lib/node_modules belong to root as they should.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some unknown reasons (cough Javascript cough), when NPM's
underscoremodule is installed (as a dependency to Obographviz), its files are given some impossibly large UID and GID. This may prevent the final image from being used on systems where Docker runs in rootless mode.So after Obographviz is installed, we ensure that all files and directories under /usr/local/lib/node_modules belong to root as they should.
closes #1156